Draft: Json chooser v2: A complex chooser to handle options #228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Just a scratch how request and response could look like.
columbarius
force-pushed
the
json-chooser-v2
branch
from
d1f3679
to
71b5067
Compare
|
Updated this with an idea to separate the chooser by using choser, chooser_opts and a target struct. |
|
being able to choose the fps would be nice as well, max_fps could be a default. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we want to query the user for options like
persist_modewe need to send more data than just the name of the output. We also need sth. more complex when window selection is possible.In any case this is a PoC sending the data encoded via json between chooser and xdpw in both directions. The scheme is versioned with
version (breaking)andrevision (backwards compatible on the xdpw side).Note: man-page has still the scheme from #105 . The new scheme is demonstrated in
chooser-protocol.json.Windows got an additional arbitrary id, since two toplevels can have the same
app_idandtitle.Supersedes: #105
CC: @emersion